Infeasible
Status Update
No update yet.
Comments
hc...@google.com
[Empty comment from Monorail migration]
ha...@google.com
Out of curiusity, tschinke, are you using a custom SkWStream that fails to report bytesWritten correctly?
ha...@google.com
[Empty comment from Monorail migration]
ha...@google.com
Unable to reproduce on my local machine with that commit and our GM and SKP tests:
cd ~/src/skia
MODE=Release
SKIA="$PWD"
git checkout 7ab42771859145884e1b28c8c45f0a5a728b22ac
gclient sync
./gyp_skia
ninja -C "out/$MODE" dm
SKPS="/tmp/$(cat SKP_VERSION)_skps"
mkdir -p "$SKPS"
(cd "$SKPS" ; "$SKIA/bin/fetch-skps")
rm -rf /tmp/pdf
out/$MODE/dm --config pdf --src skp gm --skps "$SKPS"/skps -w /tmp
GOOD='No syntax or stream encoding errors found'
for file in /tmp/pdf/*/*.pdf; do
qpdf --check $file | grep -q "$GOOD" || echo $file;
done
cd ~/src/skia
MODE=Release
SKIA="$PWD"
git checkout 7ab42771859145884e1b28c8c45f0a5a728b22ac
gclient sync
./gyp_skia
ninja -C "out/$MODE" dm
SKPS="/tmp/$(cat SKP_VERSION)_skps"
mkdir -p "$SKPS"
(cd "$SKPS" ; "$SKIA/bin/fetch-skps")
rm -rf /tmp/pdf
out/$MODE/dm --config pdf --src skp gm --skps "$SKPS"/skps -w /tmp
GOOD='No syntax or stream encoding errors found'
for file in /tmp/pdf/*/*.pdf; do
qpdf --check $file | grep -q "$GOOD" || echo $file;
done
wo...@gmail.com
That's a good point. Indeed, we are using a custom JNI-Binding to a Java Output-Stream, similar to CreateJavaOutputStreamAdaptor.c from the Android Source. I will check our implementation regarding this issue.
bu...@chromium.org
The following revision refers to this bug:
https://skia.googlesource.com/skia.git/+/4f2b33159b5a5da869ed605abf1d73b5cd429934
commit 4f2b33159b5a5da869ed605abf1d73b5cd429934
Author: halcanary <halcanary@google.com>
Date: Mon Aug 10 15:49:03 2015
SkPDF: add assert for that SkWStream behaves.
Motivation: this might catch future issues like this.
BUG=skia:4181
Review URL:https://codereview.chromium.org/1287443002
[modify]http://crrev.com/4f2b33159b5a5da869ed605abf1d73b5cd429934/src/doc/SkDocument_PDF.cpp
commit 4f2b33159b5a5da869ed605abf1d73b5cd429934
Author: halcanary <halcanary@google.com>
Date: Mon Aug 10 15:49:03 2015
SkPDF: add assert for that SkWStream behaves.
Motivation: this might catch future issues like this.
BUG=skia:4181
Review URL:
[modify]
ts...@googlemail.com
I can confirm that this was an error in our SkWStream implementation. Thank you very much.
Description
We are using a Skia-Build based on commit 7ab42771859145884e1b28c8c45f0a5a728b22ac (02.03.2015 23:07) for Android.
Output from qpdf:
$ qpdf --show-xref text.pdf
WARNING: text.pdf: file is damaged
WARNING: text.pdf: unable to find trailer while reading xref
WARNING: text.pdf: Attempting to reconstruct cross-reference table
1/0: uncompressed; offset = 15
2/0: uncompressed; offset = 63
3/0: uncompressed; offset = 119
4/0: uncompressed; offset = 316
5/0: uncompressed; offset = 410
6/0: uncompressed; offset = 193662
7/0: uncompressed; offset = 548
8/0: uncompressed; offset = 193335
9/0: uncompressed; offset = 815
10/0: uncompressed; offset = 1047
qpdf: operation succeeded with warnings; resulting file may have some problems